Time - Ross & Sharon #3
Conversation
Sharon videos branch
Ross customer branch
Ross rental tests
Sharon rental testing branch
Ross rental controller tests
Video Store APIMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
beccaelenzil
left a comment
beccaelenzil
left a comment
There was a problem hiding this comment.
Great work on this project! Your code is clear and well written. Your controllers are concise, and you've put the business logic in the model. Furthermore, your code is well tested. Keep up the hard work!
| end | ||
|
|
||
| checkout = Rental.new(rental_params) | ||
| checkout.due_date = Date.today + 7.days |
There was a problem hiding this comment.
This is a very small amount of logic, but you might consider putting this logic into a custom model method.
| @@ -0,0 +1,32 @@ | |||
| frozen: | |||
| id: 1 | |||
There was a problem hiding this comment.
It's best practice to not include ids in fixtures. They will be automatically generated.
|
|
||
|
|
||
|
|
||
| def increment_videos_checked_out_count |
There was a problem hiding this comment.
Great work putting all this logic into custom model methods. You might also consider whether any of this logic could go directly in the video and/or customer model.
3 participants
Assignment Submission: Video Store API
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.
Reflection
/customers&/videosendpoints? What does the time complexity depend on? Explain your reasoning.POST /rentals/check-inendpoint? What does the time complexity depend on? Explain your reasoning.